Skip to content

Conversation

@HowardvanRooijen
Copy link
Member

…verification tests

Copilot AI review requested due to automatic review settings January 23, 2026 18:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes Issue 306 by adding exception handling to ProgressReporter.Begin to gracefully handle clients that don't support the window/workDoneProgress/create method. When a client throws an exception during progress creation, the implementation now catches it and sets an internal flag to skip subsequent progress reporting operations.

Changes:

  • Added try-catch block in ProgressReporter.Begin to handle exceptions from unsupporting clients
  • Added comprehensive test suite for the exception handling behavior
  • Updated project file to include the new test file

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/CSharpLanguageServer/Lsp/ProgressReporter.fs Added exception handling around WindowWorkDoneProgressCreate to catch errors from clients that don't support progress reporting
tests/CSharpLanguageServer.Tests/ProgressReporterTests.fs New test file with tests verifying exception handling and no-op behavior after failed initialization
tests/CSharpLanguageServer.Tests/CSharpLanguageServer.Tests.fsproj Added reference to the new test file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants