Fix occasional segfault in WContainerWidget::widget called by WTableView::setHeaderHeight#238
Open
m-seibt wants to merge 2 commits intoemweb:masterfrom
Open
Fix occasional segfault in WContainerWidget::widget called by WTableView::setHeaderHeight#238m-seibt wants to merge 2 commits intoemweb:masterfrom
m-seibt wants to merge 2 commits intoemweb:masterfrom
Conversation
The SF occurred when calling WTableView::setHeaderHeight during WebController::doCreateApplication.
Author
|
Hi @MatthiasVC, from other PRs here, I know that you use to merge them in a bunch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WContainerWidget::widget: ThrowWExceptionon invalidindexinstead of segfaultingWTableView::headerWidget: Avoid accessing a not (yet?) existing cell widget, then returnnullptrAt least
WAbstractItemView::setHeaderHeightproperly checks fornullptr.The segfault occasionally occurred when calling
WTableView::setHeaderHeightduringWebController::doCreateApplicationwith Wt 4.12.3.Partial call stack: