Skip to content

Add leafmap and whiteboxgui recipes (#4279)#4280

Merged
IsabelParedes merged 6 commits intoemscripten-forge:mainfrom
martinRenou:4x_leafmap
Feb 19, 2026
Merged

Add leafmap and whiteboxgui recipes (#4279)#4280
IsabelParedes merged 6 commits intoemscripten-forge:mainfrom
martinRenou:4x_leafmap

Conversation

@martinRenou
Copy link
Copy Markdown
Member

@martinRenou martinRenou commented Jan 20, 2026 •
edited
Loading

No description provided.

@martinRenou martinRenou added the 4.X Emscripten v4.x label Jan 20, 2026
@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Jan 20, 2026

Needs porting #1945 to 4.x

@martinRenou martinRenou mentioned this pull request Jan 27, 2026
Closed
@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Jan 27, 2026

#4307

@IsabelParedes
Copy link
Copy Markdown
Member

IsabelParedes commented Feb 5, 2026

We might need a patch

image

@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Feb 5, 2026

Ah yeah, whitebox cannot work as-is and indeed would need some amount of work to make it work I guess.

But the initial intent of that PR is to get import leafmap to work without error. I understand leafmap falls back to an ipywidgets-base implementation of whitebox if whiteboxui cannot be used. That all that matters to me right now honestly.

So if we're fine with not having an import whiteboxui test in the recipe, and maybe just test the files are installed, I'd be fine with getting the PR in.

What do you think?

@IsabelParedes
Copy link
Copy Markdown
Member

IsabelParedes commented Feb 6, 2026

So if we're fine with not having an import whiteboxui test in the recipe, and maybe just test the files are installed, I'd be fine with getting the PR in.

What do you think?

Yes, this sounds good to me

@martinRenou martinRenou closed this Feb 6, 2026
@martinRenou martinRenou reopened this Feb 6, 2026
@IsabelParedes IsabelParedes mentioned this pull request Feb 6, 2026
Closed
13 tasks
@martinRenou martinRenou force-pushed the 4x_leafmap branch 3 times, most recently from 4dc4c92 to 0a510fc Compare February 16, 2026 08:36
martinRenou
martinRenou commented Feb 16, 2026
View reviewed changes
Comment thread recipes/recipes_emscripten/whiteboxgui/recipe.yaml Outdated
@IsabelParedes
Copy link
Copy Markdown
Member

IsabelParedes commented Feb 19, 2026

image

Affected by #4364

martinRenou and others added 5 commits February 19, 2026 16:29
@martinRenou @IsabelParedes
Add leafmap and whiteboxgui recipes (emscripten-forge#4279)
72a900f 
* Add leafmap recipe

* Missing test file

* Up

* Oups

* Missing build

* Adding whiteboxgui recipe as well

* Up

* Fix tests

* Up
@martinRenou @IsabelParedes
pin setuptools
945f211
@martinRenou @IsabelParedes
Hey
9aadfd8
@IsabelParedes
Fix whiteboxgui tests
c26af49
@IsabelParedes
Bypass leafmap tests
df34477
@IsabelParedes IsabelParedes merged commit 98d929b into emscripten-forge:main Feb 19, 2026
2 checks passed
@martinRenou martinRenou deleted the 4x_leafmap branch February 19, 2026 15:51
@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Feb 19, 2026

Thanks a ton for getting this through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

4.X Emscripten v4.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martinRenou @IsabelParedes