Fix for window very-long-filename support. NFC #1646
Merged
+60
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a function called
fix_potentially_long_windows_pathnamewhich is used when unzipping archives under windows.Without this the unzip process will fail if the total filename length ever exceeds 256. This change adds a test for installing deep in the filesystem (where pathnames exceed 256) and fixes a bug in this code which was causing the test to fail.
The fact that this code had this bug for god-known-how-long means I think nobody was depending on it, so we could probably just remove it, but maybe better to fix it and add this test?