emit-tsd: support multi-value-return wasm functions instead of asserting#26965
Closed
guybedford wants to merge 1 commit into
Closed
emit-tsd: support multi-value-return wasm functions instead of asserting#26965guybedford wants to merge 1 commit into
guybedford wants to merge 1 commit into
Conversation
A wasm function returning multiple values (e.g. wasm-bindgen's ptr+len pair for `pub fn foo() -> String`) tripped a hard assertion in `create_tsd` and aborted the whole --emit-tsd pass. Surface multi-value returns as a TypeScript tuple type instead.
Collaborator
Author
|
Closing in favour of #26966. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A wasm function returning multiple values trips a hard assertion in
create_tsdand aborts the whole--emit-tsdpass:Multi-value return is standardized wasm and shows up in real toolchains — most notably wasm-bindgen, which emits
(i32, i32)ptr+len pairs for any Rust export returningString,Vec<u8>,Result<T, E>, etc. onwasm32-unknown-emscripten. The wasm is valid; only the TSD pass crashes.Replace the assert with the natural translation: a wasm function returning
(i32, i32)becomes a TS function returning[number, number]. Empty- and single-return paths are unchanged.The raw tuple isn't always what consumers ultimately want (wasm-bindgen's JS glue wraps these into a single JS value), but emitting something lets the
.d.tsparse and lets downstream.d.tsmergers intersect with more precise types.Test:
test/other/test_emit_tsd_multivalue.ccompiles a struct-returning function with-mmultivalue -Xclang -target-abi -Xclang experimental-mvand asserts the generated.d.tscontains the tuple type. Without the fix the new test reproduces the originalAssertionError; with it, all existing--emit-tsdtests continue to pass.