Skip to content

Update libpng.py to 1.6.56#26592

Merged
sbc100 merged 8 commits into
emscripten-core:mainfrom
HCL-TECH-SOFTWARE:libpng-to-1.6.56
May 19, 2026
Merged

Update libpng.py to 1.6.56#26592
sbc100 merged 8 commits into
emscripten-core:mainfrom
HCL-TECH-SOFTWARE:libpng-to-1.6.56

Conversation

@HCL-JasonR
Copy link
Copy Markdown
Contributor

Comment thread tools/ports/libpng.py Outdated

def get(ports, settings, shared):
# This is an emscripten-hosted mirror of the libpng repo from Sourceforge.
# Reviewer - please add libpng-1.6.56 binary to storage
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Copy Markdown
Contributor Author

@HCL-JasonR HCL-JasonR Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll write up a ChangeLog entry and remove this comment.

@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented Apr 1, 2026

Maybe add a ChangeLot entry?

@sbc100 sbc100 enabled auto-merge (squash) April 1, 2026 17:44
@dasa
Copy link
Copy Markdown
Contributor

dasa commented May 6, 2026

@HCL-JasonR thanks for creating this PR! Can you try bringing your branch up to date with main? Maybe that'll fix the tests.

auto-merge was automatically disabled May 7, 2026 19:13

Head branch was pushed to by a user without write access

@HCL-JasonR
Copy link
Copy Markdown
Contributor Author

Thanks for the reminder on this, dasa. I just merged main into the PR source branch.

@dasa
Copy link
Copy Markdown
Contributor

dasa commented May 7, 2026

Looks like this might need to be updated too:

typedef png_libpng_version_1_6_55 Your_png_h_is_not_version_1_6_55;

Comment thread ChangeLog.md Outdated
@dasa
Copy link
Copy Markdown
Contributor

dasa commented May 12, 2026

@HCL-JasonR maybe another merge from main will fix this?

@dasa
Copy link
Copy Markdown
Contributor

dasa commented May 18, 2026

Friendly ping 😄

@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented May 18, 2026

@HCL-JasonR it looks like we (emscripten maintainers) don't have permission to rebase your branch to fix the conflicts. Would you have time to do it?

If not we can ask @dasa to take this on in a separate PR?

@HCL-JasonR
Copy link
Copy Markdown
Contributor Author

My apologies, this kept making my "fix it this afternoon" list and getting bumped.

I just merged emscripten-core/emscripten main with no merge conflicts and pushed the updates.

@sbc100 sbc100 merged commit 9563db7 into emscripten-core:main May 19, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants