Fix null deref in ppoll/pselect#26533
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 24, 2026
Merged
Conversation
This fixes the current failure of asan.test_ppoll_blocking on the emsdk waterfall.
dschuff
approved these changes
Mar 24, 2026
dschuff
reviewed
Mar 24, 2026
| int timeout = (to == NULL) ? -1 : (to->tv_sec * 1000 + to->tv_nsec / 1000000); | ||
| sigset_t origmask; | ||
| pthread_sigmask(SIG_SETMASK, mask, &origmask); | ||
| if (mask) pthread_sigmask(SIG_SETMASK, mask, &origmask); |
Member
There was a problem hiding this comment.
is it valid to have a null mask? should we return an error?
Collaborator
Author
There was a problem hiding this comment.
Yes, from the ppoll man page:
If the sigmask argument is specified as NULL, then no signal mask manipulation is performed (and thus ppoll() differs from poll() only in the precision of the timeout
argument).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the current failure of asan.test_ppoll_blocking on the emsdk waterfall.