Skip to content

Remove thread profiler completely from non-pthreads builds. NFC #26488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Mar 20, 2026
Merged

Remove thread profiler completely from non-pthreads builds. NFC #26488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/lib/pthread/threading_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void _emscripten_thread_exit_joinable(pthread_t thread);
void _emscripten_thread_exit(void* result);
void _emscripten_process_dlopen_queue(void);

#ifdef NDEBUG
#if !defined(__EMSCRIPTEN_PTHREADS__) || defined(NDEBUG)
#define emscripten_set_current_thread_status(newStatus)
#define emscripten_conditional_set_current_thread_status(expectedStatus, newStatus)
#else
Expand Down
6 changes: 2 additions & 4 deletions test/codesize/test_codesize_hello_dylink_all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"a.out.js": 244367,
"a.out.nodebug.wasm": 577323,
"total": 821690,
"a.out.nodebug.wasm": 577288,
"total": 821655,
"sent": [
"IMG_Init",
"IMG_Load",
Expand Down Expand Up @@ -2243,7 +2243,6 @@
"emscripten_proxy_sync",
"emscripten_proxy_sync_with_ctx",
"emscripten_scan_stack",
"emscripten_set_thread_name",
"emscripten_stack_get_base",
"emscripten_stack_get_current",
"emscripten_stack_get_end",
Expand Down Expand Up @@ -4100,7 +4099,6 @@
"$emscripten_proxy_async",
"$emscripten_proxy_execute_queue",
"$emscripten_scan_stack",
"$emscripten_set_thread_name",
"$emscripten_stack_get_base",
"$emscripten_stack_get_current",
"$emscripten_stack_get_end",
Expand Down
5 changes: 1 addition & 4 deletions tools/system_libs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,6 +1211,7 @@ def get_files(self):
'pthread_kill.c',
'emscripten_thread_init.c',
'emscripten_yield.c',
'thread_profiler.c',
])
else:
ignore += ['thread']
Expand Down Expand Up @@ -1412,10 +1413,6 @@ def get_files(self):
if settings.MAIN_MODULE:
libc_files += files_in_path(path='system/lib/libc', filenames=['dynlink.c'])

libc_files += files_in_path(
path='system/lib/pthread',
filenames=['thread_profiler.c'])

libc_files += glob_in_path('system/lib/libc/compat', '*.c')

# Check for missing file in non_lto_files list. Do this here
Expand Down
Loading