Use bool return type for various low-level emscripten APIs#26316
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Use bool return type for various low-level emscripten APIs#26316sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
use_bool_return
branch
from
09d38c8 to
bba58a9
Compare
sbc100
changed the title
kripken
reviewed
Feb 21, 2026
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Please also add a changelog entry. lgtm with that + comments
We converted a EM_BOOL from `int` to `bool` without too much fallout so I think should a backwards compatible change for all users. It is of course conceivable to construct code that would notice this change (e.g. `sizeof(emscripten_is_main_runtime_thread())` but its seems extremely unlikely. I think using the explicit bool type helps make these function more clear, and avoids confusion with tradition "0 means success" C functions.
sbc100
force-pushed
the
use_bool_return
branch
from
bba58a9 to
3d20945
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We converted a
EM_BOOLfrominttoboolwithout too much fallout soI think should a backwards compatible change for all users.
It is of course conceivable to construct code that would notice this change (e.g.
sizeof(emscripten_is_main_runtime_thread())but its seems extremely unlikely.I think using the explicit bool type helps make these function more
clear, and avoids confusion with tradition "0 means success" C
functions.