Improve emscripten_futex_wait stub. NFC#26309
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Improve emscripten_futex_wait stub. NFC#26309sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
futex_wait_workers
branch
3 times, most recently
from
7ce2891 to
e36db36
Compare
Collaborator
Author
|
This was also causing some confusion in #26283 |
The test for wasm workers with `emscripten_futex_wait` was added in back in emscripten-core#21618 but AFAICT it was only even working when pthread support was also enabled. However because the stub was simply returning 0 in all cases it was enough to make it seems as if the API was working when it wasn't. Indeed the `test/webaudio/audioworklet_worker.c` test seems to have been written under the assumption that this API was available for use in wasm workers. It seems better to return ENOTSUP unless the API is actually available.
sbc100
force-pushed
the
futex_wait_workers
branch
from
e36db36 to
1cd0d28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test for wasm workers with emscripten_futex_wait was added in back in #21618 but AFAICT it was only even working when pthread support was also enabled.
Then pthread support is not enabled only the stub version is used which obviously doesn't work as expected.
I think it would be great to get this API working in pure wasm workers, but that is separate issue.