Remove loadSplitModule from default INCOMING_MODULE_JS_API. NFC
#26194
+16
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can instead add it to the list precisely in cases where its needed.
sbc100
force-pushed
the
loadSplitModule
branch
from
b0e602d to
a8f9ec2
Compare
sbc100
commented
Feb 1, 2026
Collaborator
Author
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
The code size changes here only occur with ASSERTIONS (since we have assertions for things that you might need to add to INCOMING_MODULE_JS_API)
kripken
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can instead add it to the list precisely in cases where its needed.