[libfetch] Add missing JS library dependencies#26011
Open
kypp wants to merge 1 commit intoemscripten-core:mainfrom
Open
[libfetch] Add missing JS library dependencies#26011kypp wants to merge 1 commit intoemscripten-core:mainfrom
kypp wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a dead code elimination (DCE) issue in MODULARIZE builds where the Fetch API uses IndexedDB. The Fetch.init() function calls addRunDependency/removeRunDependency when IndexedDB support is enabled, but these helper functions were being removed by DCE, causing a ReferenceError at runtime.
- Adds
$addRunDependencyand$removeRunDependencyas dependencies of$FetchwhenFETCH_SUPPORT_INDEXEDDBis enabled - Prevents DCE from removing these runtime helper functions in MODULARIZE builds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sbc100
reviewed
Dec 30, 2025
Collaborator
sbc100
left a comment
There was a problem hiding this comment.
Can we add a test for this (maybe update one of the existing fetch tests under test/fetch/..?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: keep run dependency helpers when FETCH uses IndexedDB
Fetch.init()callsaddRunDependency/removeRunDependencywhenFETCH_SUPPORT_INDEXEDDBis enabled. In-s MODULARIZE=1builds those helpers can be DCE'd, causingReferenceError: addRunDependency is not definedat runtime.This change declares
$addRunDependencyand$removeRunDependencyas deps of$Fetch(guarded byFETCH_SUPPORT_INDEXEDDB), so the helpers are retained without requiring extra user flags.Fixes #26008
Repro:
Open the output in a browser:
ReferenceError: addRunDependency is not defined