Open
Conversation
|
View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grid_color(Color32)— sets the base color for grid lines independently oftext_color(), while preserving the strength-based fading.grid_fade(f32)— controls the contrast between dense and sparse grid lines.0.0= uniform (all lines same opacity),0.5= default (sqrt),1.0= maximum fade. The zoom-based density logic is always preserved.Motivation
When embedding
egui_plotin an application with its own design system, the grid color needs to be independent of text color. The current behavior derives grid color fromui.visuals().text_color(), which couples grid styling to text styling.Similarly, the strength curve (hardcoded
sqrt) may not suit all visual designs — some applications want less contrast between grid levels, or uniform grid lines.Changes
Single file change in
plot.rs:grid_color: Option<Color32>field with.grid_color()builder methodgrid_strength_exponent: f32field (default0.5) with.grid_fade()builder methodpaint_grid_directionuses the custom base color and exponent when set, falls back to existing behavior otherwise