-
Notifications
You must be signed in to change notification settings - Fork 94
Add ability to specify color and font of axis tick labels for each axis #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7b09ce3
Add ability to change tick label color and size for each axis
c290139
change AxisHints::tick_label_color to take an into<Color32> rather th…
7d0ff18
import Color32 and FontId directly, clean up method docs
79eb72d
Merge branch 'main' into feat/tick-label-decoration
TommiKabelitz dd6f178
Merge branch 'main' into feat/tick-label-decoration
TommiKabelitz 4482ec8
use unwrap_or_else
emilk 9a6eb0c
Merge branch 'main' into feat/tick-label-decoration
emilk 46ac8a9
cargo fmt
emilk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the default?
maybe set it to a default which we already use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else use Default::default()
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the default is whatever is in
ui.visuals().text_color()when the plot is actually rendered because this functionis called to determine the color when the plot is shown.
I am still just calling this function when color is
Noneso the behavior is not changing. I could potentially move the default to the instantiation ofAxisHints, but that would change the behavior in cases whereui.visuals().text_color()is changed between creation of the axes and showing the plot.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me