Remove @ember/runloop from initializer test blueprints

[cloke]

Summary

Remove @ember/runloop usage in initializer/instance-initializer test blueprints and fixtures by calling destroy directly when destroyApp helper is unavailable.

Testing

• pnpm vite build --mode=development
• CI=1 CHROME_BIN="/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" pnpm test
• pnpm build
• pnpm test:node
• pnpm test:blueprints

Fixes #20690

[github-actions]

Estimated Asset Sizes

Diff

Details

This PR

main

╔═══════╤═══════════╤═══════════╗ ║ │ Min │ Gzip ║ ╟───────┼───────────┼───────────╢ ║ Total │ 352.26 KB │ 203.67 KB ║ ╚═══════╧═══════════╧═══════════╝ ╔══════════════════════╤═══════════╤═══════════╗ ║ @ember/* │ Min │ Gzip ║ ╟──────────────────────┼───────────┼───────────╢ ║ Total │ 313.87 KB │ 181.82 KB ║ ╟──────────────────────┼───────────┼───────────╢ ║ -internals │ 36.68 KB │ 26.02 KB ║ ║ application │ 13.24 KB │ 8.03 KB ║ ║ array │ 13.05 KB │ 7.54 KB ║ ║ canary-features │ 304 B │ 419 B ║ ║ component │ 2.05 KB │ 1.56 KB ║ ║ controller │ 1.96 KB │ 1.45 KB ║ ║ debug │ 11.73 KB │ 8.14 KB ║ ║ deprecated-features │ 31 B │ 77 B ║ ║ destroyable │ 561 B │ 383 B ║ ║ enumerable │ 259 B │ 387 B ║ ║ helper │ 1.08 KB │ 805 B ║ ║ instrumentation │ 2.43 KB │ 1.78 KB ║ ║ modifier │ 1.22 KB │ 1011 B ║ ║ object │ 35.98 KB │ 22.1 KB ║ ║ owner │ 159 B │ 178 B ║ ║ renderer │ 630 B │ 508 B ║ ║ routing │ 59.37 KB │ 33.92 KB ║ ║ runloop │ 2.36 KB │ 1.5 KB ║ ║ service │ 1 KB │ 858 B ║ ║ template │ 654 B │ 523 B ║ ║ template-compilation │ 429 B │ 366 B ║ ║ template-compiler │ 123.33 KB │ 59.68 KB ║ ║ template-factory │ 370 B │ 351 B ║ ║ test │ 923 B │ 627 B ║ ║ utils │ 4.11 KB │ 3.63 KB ║ ║ version │ 55 B │ 131 B ║ ╚══════════════════════╧═══════════╧═══════════╝ ╔═════════════════╤══════════╤══════════╗ ║ @glimmer/* │ Min │ Gzip ║ ╟─────────────────┼──────────┼──────────╢ ║ Total │ 38.38 KB │ 21.85 KB ║ ╟─────────────────┼──────────┼──────────╢ ║ destroyable │ 2.78 KB │ 1.38 KB ║ ║ encoder │ 81 B │ 171 B ║ ║ env │ 38 B │ 87 B ║ ║ global-context │ 886 B │ 545 B ║ ║ manager │ 977 B │ 627 B ║ ║ node │ 175 B │ 244 B ║ ║ opcode-compiler │ 1.11 KB │ 905 B ║ ║ owner │ 159 B │ 202 B ║ ║ program │ 252 B │ 333 B ║ ║ reference │ 548 B │ 544 B ║ ║ runtime │ 10.32 KB │ 5.3 KB ║ ║ tracking │ 1.34 KB │ 1.18 KB ║ ║ util │ 1.94 KB │ 1.6 KB ║ ║ validator │ 15.53 KB │ 6.9 KB ║ ║ vm │ 495 B │ 569 B ║ ║ wire-format │ 1.84 KB │ 1.35 KB ║ ╚═════════════════╧══════════╧══════════╝

╔═══════╤═══════════╤═══════════╗ ║ │ Min │ Gzip ║ ╟───────┼───────────┼───────────╢ ║ Total │ 352.26 KB │ 203.67 KB ║ ╚═══════╧═══════════╧═══════════╝ ╔══════════════════════╤═══════════╤═══════════╗ ║ @ember/* │ Min │ Gzip ║ ╟──────────────────────┼───────────┼───────────╢ ║ Total │ 313.87 KB │ 181.82 KB ║ ╟──────────────────────┼───────────┼───────────╢ ║ -internals │ 36.68 KB │ 26.02 KB ║ ║ application │ 13.24 KB │ 8.03 KB ║ ║ array │ 13.05 KB │ 7.54 KB ║ ║ canary-features │ 304 B │ 419 B ║ ║ component │ 2.05 KB │ 1.56 KB ║ ║ controller │ 1.96 KB │ 1.45 KB ║ ║ debug │ 11.73 KB │ 8.14 KB ║ ║ deprecated-features │ 31 B │ 77 B ║ ║ destroyable │ 561 B │ 383 B ║ ║ enumerable │ 259 B │ 387 B ║ ║ helper │ 1.08 KB │ 805 B ║ ║ instrumentation │ 2.43 KB │ 1.78 KB ║ ║ modifier │ 1.22 KB │ 1011 B ║ ║ object │ 35.98 KB │ 22.1 KB ║ ║ owner │ 159 B │ 178 B ║ ║ renderer │ 630 B │ 508 B ║ ║ routing │ 59.37 KB │ 33.92 KB ║ ║ runloop │ 2.36 KB │ 1.5 KB ║ ║ service │ 1 KB │ 858 B ║ ║ template │ 654 B │ 523 B ║ ║ template-compilation │ 429 B │ 366 B ║ ║ template-compiler │ 123.33 KB │ 59.68 KB ║ ║ template-factory │ 370 B │ 351 B ║ ║ test │ 923 B │ 627 B ║ ║ utils │ 4.11 KB │ 3.63 KB ║ ║ version │ 55 B │ 131 B ║ ╚══════════════════════╧═══════════╧═══════════╝ ╔═════════════════╤══════════╤══════════╗ ║ @glimmer/* │ Min │ Gzip ║ ╟─────────────────┼──────────┼──────────╢ ║ Total │ 38.38 KB │ 21.85 KB ║ ╟─────────────────┼──────────┼──────────╢ ║ destroyable │ 2.78 KB │ 1.38 KB ║ ║ encoder │ 81 B │ 171 B ║ ║ env │ 38 B │ 87 B ║ ║ global-context │ 886 B │ 545 B ║ ║ manager │ 977 B │ 627 B ║ ║ node │ 175 B │ 244 B ║ ║ opcode-compiler │ 1.11 KB │ 905 B ║ ║ owner │ 159 B │ 202 B ║ ║ program │ 252 B │ 333 B ║ ║ reference │ 548 B │ 544 B ║ ║ runtime │ 10.32 KB │ 5.3 KB ║ ║ tracking │ 1.34 KB │ 1.18 KB ║ ║ util │ 1.94 KB │ 1.6 KB ║ ║ validator │ 15.53 KB │ 6.9 KB ║ ║ vm │ 495 B │ 569 B ║ ║ wire-format │ 1.84 KB │ 1.35 KB ║ ╚═════════════════╧══════════╧══════════╝

[NullVoxPopuli]

do we really still support destroy-app? O>o

[kategengler]

That's part of that old-style of testing that we talked about that I don't think was ever deprecated. It is possible it was broken at the blueprint side, though.

[NullVoxPopuli]

Thanks for doing this -- there is potential we could remove more tho -- trying to figure that out 🤔