Skip to content

Replace ember-engines.com references with GitHub repository URL#21022

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/update-ember-engines-links
Closed

Replace ember-engines.com references with GitHub repository URL#21022
Copilot wants to merge 2 commits intomainfrom
copilot/update-ember-engines-links

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 31, 2025

The ember-engines.com domain has been lost and now points to an unrelated AI content site. Updated all references to use the GitHub repository URL instead.

Changes

  • Updated assertion message in LinkTo component validation
  • Updated corresponding test assertion strings in routing tests
// Before
'See https://ember-engines.com/docs/links for more info.'

// After  
'See https://github.com/ember-engines/ember-engines/ for more info.'

Files changed:

  • packages/@ember/-internals/glimmer/lib/components/link-to.ts
  • packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-angle-test.js
  • packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-curly-test.js
Original prompt

Find and replace any references to 'ember-engines.com' throughout the repository, including documentation comments and test assertion strings, with 'https://github.com/ember-engines/ember-engines/'. Where 'ember-engines.com' is used as a link, update the href to point to the GitHub repository. Where it appears in documentation or assertions, update the text accordingly. Add a note to the PR description that this is due to the domain having been lost and now belonging to an unrelated AI content site.

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Copilot AI changed the title [WIP] Update references from ember-engines.com to GitHub repository Replace ember-engines.com references with GitHub repository URL Dec 31, 2025
Copilot AI requested a review from NullVoxPopuli December 31, 2025 16:21
@johanrd
Copy link
Copy Markdown
Contributor

johanrd commented Mar 7, 2026

@NullVoxPopuli this can be closed i think,

Seems already fixed on main:

'You attempted to use the <LinkTo> component within a routeless engine, this is not supported. ' +
'If you are using the ember-engines addon, use the <LinkToExternal> component instead. ' +
'See https://github.com/ember-engines/ember-engines for more info.'

'You attempted to use the <LinkTo> component within a routeless engine, this is not supported. ' +
'If you are using the ember-engines addon, use the <LinkToExternal> component instead. ' +
'See https://github.com/ember-engines/ember-engines for more info.'

'You attempted to use the <LinkTo> component within a routeless engine, this is not supported. ' +
'If you are using the ember-engines addon, use the <LinkToExternal> component instead. ' +
'See https://github.com/ember-engines/ember-engines for more info.'

@NullVoxPopuli NullVoxPopuli deleted the copilot/update-ember-engines-links branch March 7, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants