Skip to content

Update ember-eslint-parser#2631

Merged
NullVoxPopuli merged 2 commits intomasterfrom
nvp/update-ember-eslint-parser
Mar 24, 2026
Merged

Update ember-eslint-parser#2631
NullVoxPopuli merged 2 commits intomasterfrom
nvp/update-ember-eslint-parser

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

No description provided.

@NullVoxPopuli
Copy link
Copy Markdown
Contributor Author

TODO: need a benchmark to see before and after

NullVoxPopuli and others added 2 commits March 24, 2026 14:15
ember-eslint-parser now uses GlimmerBlockParam (via ember-estree)
for consistency with all other Glimmer-prefixed node types.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@NullVoxPopuli NullVoxPopuli force-pushed the nvp/update-ember-eslint-parser branch from 9f40413 to f5207c2 Compare March 24, 2026 18:15
@github-actions
Copy link
Copy Markdown
Contributor

🏎️ Benchmark Comparison

Benchmark Control (p50) Experiment (p50) Δ
js small 13.86 ms 14.00 ms +1.0%
🟢 js medium 7.05 ms 6.88 ms -2.3%
js large 2.79 ms 2.74 ms -1.6%
gjs small 1.25 ms 1.26 ms +0.2%
gjs medium 622.37 µs 621.43 µs -0.1%
gjs large 248.78 µs 246.23 µs -1.0%
gts small 1.24 ms 1.22 ms -1.0%
gts medium 619.90 µs 615.26 µs -0.7%
gts large 245.46 µs 246.82 µs +0.6%

🟢 faster · 🔴 slower · 🟠 slightly slower · ⚪ within 2%

Full mitata output
clk: ~3.09 GHz
cpu: AMD EPYC 7763 64-Core Processor
runtime: node 24.14.0 (x64-linux)

benchmark                   avg (min … max) p75 / p99    (min … top 1%)
------------------------------------------- -------------------------------
js small (control)            16.54 ms/iter  18.34 ms █▂▂                  
                      (12.18 ms … 30.14 ms)  28.01 ms ███     ▅            
                    (  5.98 mb …  10.54 mb)   7.24 mb ███▇▄▁▄▇█▄▁▁▄▄▁▁▄▄▄▁▄

js small (experiment)         14.68 ms/iter  15.66 ms  ████                
                      (12.81 ms … 19.32 ms)  18.94 ms  ████    █           
                    (  6.42 mb …   8.09 mb)   6.84 mb ██████▁▅▁█▅▅█▁▅▁▁▁▅▅▅

                             ┌                                            ┐
                             ╷┌──────────┬────┐                           ╷
          js small (control) ├┤          │    ├───────────────────────────┤
                             ╵└──────────┴────┘                           ╵
                               ╷ ┌──┬──┐        ╷
       js small (experiment)   ├─┤  │  ├────────┤
                               ╵ └──┴──┘        ╵
                             └                                            ┘
                             12.18 ms           20.10 ms           28.01 ms

summary
  js small (experiment)
   1.13x faster than js small (control)

------------------------------------------- -------------------------------
js medium (control)            7.62 ms/iter   7.78 ms  █▂                  
                       (6.40 ms … 15.11 ms)  14.07 ms ▇██                  
                    (  2.95 mb …   4.39 mb)   3.55 mb ███▅▆▅▅▂▂▁▂▂▂▁▂▁▁▁▁▂▂

js medium (experiment)         7.42 ms/iter   7.62 ms   █                  
                       (6.40 ms … 12.77 ms)  11.14 ms  ▄█                  
                    (  2.80 mb …   3.97 mb)   3.52 mb ███▅▃▄▃▂▃▃▅▂▁▁▃▁▂▁▂▁▃

                             ┌                                            ┐
                             ╷ ┌────┬┐                                    ╷
         js medium (control) ├─┤    │├────────────────────────────────────┤
                             ╵ └────┴┘                                    ╵
                             ╷ ┌───┬┐                    ╷
      js medium (experiment) ├─┤   │├────────────────────┤
                             ╵ └───┴┘                    ╵
                             └                                            ┘
                             6.40 ms           10.23 ms            14.07 ms

summary
  js medium (experiment)
   1.03x faster than js medium (control)

------------------------------------------- -------------------------------
js large (control)             3.18 ms/iter   2.91 ms  █                   
                        (2.39 ms … 9.78 ms)   8.53 ms  █                   
                    ( 35.28 kb …   2.75 mb)   1.43 mb ██▅▂▃▂▁▁▂▂▁▂▁▁▁▁▁▁▁▁▁

js large (experiment)          3.00 ms/iter   2.84 ms  █                   
                        (2.55 ms … 7.56 ms)   5.91 ms ▃█                   
                    (267.28 kb …   2.32 mb)   1.43 mb ██▅▂▂▂▂▂▂▁▁▁▁▁▁▁▁▁▁▁▁

                             ┌                                            ┐
                             ╷  ┌──┬                                      ╷
          js large (control) ├──┤  │──────────────────────────────────────┤
                             ╵  └──┴                                      ╵
                              ╷┌─┬                     ╷
       js large (experiment)  ├┤ │─────────────────────┤
                              ╵└─┴                     ╵
                             └                                            ┘
                             2.39 ms            5.46 ms             8.53 ms

summary
  js large (experiment)
   1.06x faster than js large (control)

------------------------------------------- -------------------------------
gjs small (control)            1.37 ms/iter   1.32 ms █                    
                        (1.20 ms … 5.93 ms)   4.79 ms █▂                   
                    ( 84.91 kb …   1.60 mb)   1.06 mb ██▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁

gjs small (experiment)         1.37 ms/iter   1.30 ms █                    
                        (1.20 ms … 6.17 ms)   4.91 ms █                    
                    (330.04 kb …   1.82 mb)   1.06 mb █▇▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁

                             ┌                                            ┐
                             ┌─┬                                         ╷
         gjs small (control) │ │─────────────────────────────────────────┤
                             └─┴                                         ╵
                             ┌─┬                                          ╷
      gjs small (experiment) │ │──────────────────────────────────────────┤
                             └─┴                                          ╵
                             └                                            ┘
                             1.20 ms            3.05 ms             4.91 ms

summary
  gjs small (experiment)
   1x faster than gjs small (control)

------------------------------------------- -------------------------------
gjs medium (control)         668.49 µs/iter 642.42 µs █                    
                      (592.71 µs … 4.63 ms)   2.90 ms █                    
                    (490.02 kb …   1.46 mb) 545.19 kb █▅▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁

gjs medium (experiment)      667.61 µs/iter 640.57 µs  █                   
                      (591.01 µs … 4.73 ms)   1.65 ms ▇█                   
                    ( 99.41 kb …   1.21 mb) 543.17 kb ██▃▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁

                             ┌                                            ┐
                             ┌─┬                                          ╷
        gjs medium (control) │ │──────────────────────────────────────────┤
                             └─┴                                          ╵
                             ┌┬                   ╷
     gjs medium (experiment) ││───────────────────┤
                             └┴                   ╵
                             └                                            ┘
                             591.01 µs           1.75 ms            2.90 ms

summary
  gjs medium (experiment)
   1x faster than gjs medium (control)

------------------------------------------- -------------------------------
gjs large (control)          267.80 µs/iter 260.69 µs  █▅                  
                      (235.50 µs … 4.08 ms) 368.15 µs  ██ ▂                
                    (172.27 kb … 902.69 kb) 218.10 kb ▆██▇██▃▂▂▂▁▁▁▁▁▁▁▁▁▁▁

gjs large (experiment)       264.29 µs/iter 258.21 µs  █                   
                      (235.15 µs … 4.46 ms) 328.37 µs  █▄▂                 
                    (181.91 kb … 809.73 kb) 217.39 kb ▅███▄█▅▆▂▂▂▂▁▁▁▁▁▁▁▁▁

                             ┌                                            ┐
                             ╷ ┌────────┬                                 ╷
         gjs large (control) ├─┤        │─────────────────────────────────┤
                             ╵ └────────┴                                 ╵
                             ╷ ┌───────┬                     ╷
      gjs large (experiment) ├─┤       │─────────────────────┤
                             ╵ └───────┴                     ╵
                             └                                            ┘
                             235.15 µs         301.65 µs          368.15 µs

summary
  gjs large (experiment)
   1.01x faster than gjs large (control)

------------------------------------------- -------------------------------
gts small (control)            1.32 ms/iter   1.26 ms █                    
                        (1.19 ms … 6.06 ms)   4.89 ms █                    
                    (897.84 kb …   1.25 mb)   1.06 mb █▃▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁

gts small (experiment)         1.32 ms/iter   1.25 ms █                    
                        (1.19 ms … 5.58 ms)   4.73 ms █                    
                    ( 49.55 kb …   2.08 mb)   1.06 mb █▄▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁

                             ┌                                            ┐
                             ┌─┬                                          ╷
         gts small (control) │ │──────────────────────────────────────────┤
                             └─┴                                          ╵
                             ┌─┬                                        ╷
      gts small (experiment) │ │────────────────────────────────────────┤
                             └─┴                                        ╵
                             └                                            ┘
                             1.19 ms            3.04 ms             4.89 ms

summary
  gts small (experiment)
   1.01x faster than gts small (control)

------------------------------------------- -------------------------------
gts medium (control)         663.87 µs/iter 636.55 µs  █                   
                      (586.41 µs … 4.67 ms)   1.14 ms  █▆                  
                    (498.70 kb …   1.53 mb) 544.76 kb ███▃▃▁▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁

gts medium (experiment)      661.21 µs/iter 632.99 µs █                    
                      (584.89 µs … 4.62 ms)   2.33 ms █▂                   
                    ( 36.05 kb …   1.04 mb) 541.95 kb ██▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁

                             ┌                                            ┐
                             ╷┌┬           ╷
        gts medium (control) ├┤│───────────┤
                             ╵└┴           ╵
                             ╷┌┬                                          ╷
     gts medium (experiment) ├┤│──────────────────────────────────────────┤
                             ╵└┴                                          ╵
                             └                                            ┘
                             584.89 µs           1.46 ms            2.33 ms

summary
  gts medium (experiment)
   1x faster than gts medium (control)

------------------------------------------- -------------------------------
gts large (control)          264.19 µs/iter 257.45 µs  █                   
                      (233.96 µs … 4.44 ms) 407.64 µs ██▂▃                 
                    (171.48 kb …   1.24 mb) 217.70 kb ████▇▂▂▂▁▁▁▁▁▁▁▁▁▁▁▁▁

gts large (experiment)       264.63 µs/iter 257.32 µs  █                   
                      (233.20 µs … 4.40 ms) 341.33 µs  █▄▇                 
                    (121.41 kb …   1.30 mb) 217.65 kb ▇████▇▆▄▂▂▂▂▁▁▁▁▁▁▁▁▁

                             ┌                                            ┐
                             ╷┌──────┬                                    ╷
         gts large (control) ├┤      │────────────────────────────────────┤
                             ╵└──────┴                                    ╵
                             ╷┌──────┬                   ╷
      gts large (experiment) ├┤      │───────────────────┤
                             ╵└──────┴                   ╵
                             └                                            ┘
                             233.20 µs         320.42 µs          407.64 µs

summary
  gts large (control)
   1x faster than gts large (experiment)

@NullVoxPopuli NullVoxPopuli merged commit 1af234b into master Mar 24, 2026
10 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/update-ember-eslint-parser branch March 24, 2026 18:37
@github-actions github-actions bot mentioned this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant