WIP: invalid indentation for multiline <Form::Element> (failing test)#2
Open
jelhan wants to merge 1 commit intoember-bootstrap:masterfrom
Conversation
This adds a failing test that indentation is invalid (accordingly to default template linting) if `<Form::Element>` uses multiple lines for it's arguments and attributes on input: Taking this input: ```hbs <form.element @Property="foo"> @Placeholder="foo"> /> ``` I would expect an output, which passes template linting. An example would be: ```hbs <form.element @Property="foo" as |el| > <el.control placeholder="foo" /> </form.element> ``` But I see this one as demonstrated by failing test: ```hbs <form.element @Property="foo" as |el|><el.control placeholder="foo" /></form.element> ``` Template linter throws errors due to indentation of `</form.element>` and `<el.control />`.
Contributor
|
Confirmed. But I believe there is not much we can do about it. Related: ember-template-lint/ember-template-recast#82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a failing test that indentation is invalid (accordingly to default template linting) if
<Form::Element>uses multiple lines for it's arguments and attributes on input:Taking this input:
I would expect an output, which passes template linting. An example would be:
But I see this one as demonstrated by failing test:
Template linter throws errors due to indentation of
</form.element>and<el.control />.