Domain: UseCases, ContentItem, Id and Instant Logic, expand tests#46
Closed
lyzlovazlata wants to merge 0 commit intoembedded-dev-research:mainfrom
Closed
Domain: UseCases, ContentItem, Id and Instant Logic, expand tests#46lyzlovazlata wants to merge 0 commit intoembedded-dev-research:mainfrom
lyzlovazlata wants to merge 0 commit intoembedded-dev-research:mainfrom
Conversation
Contributor
lyzlovazlata
commented
Apr 6, 2026
- Add deafult usecases with notes
- Edit ContentItem - add id of each
- Add ContentItemUseCases
- Sorted UseCases packages
- Add and expand tests
Member
|
Thanks for the work here. There is a lot of useful progress in this PR. For review, I think it would be much easier if this were split into a few smaller PRs. Right now this branch seems to include several different kinds of changes at once:
The reason I suggest this is not that the work is wrong. It is just hard to review and debug when architectural changes, new logic, tests, and build/config updates all come together in one PR. Smaller PRs would make it easier to:
One possible split could be:
It does not have to be exactly this split, but separating the bigger architectural changes from the feature logic would already make the review much easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.