Skip to content

Drop old elixir support, fix integration tests#119

Merged
mhanberg merged 2 commits into
elixir-wallaby:masterfrom
phinnaeus:modernize-elixir-req
Jun 7, 2026
Merged

Drop old elixir support, fix integration tests#119
mhanberg merged 2 commits into
elixir-wallaby:masterfrom
phinnaeus:modernize-elixir-req

Conversation

@phinnaeus
Copy link
Copy Markdown
Contributor

@phinnaeus phinnaeus commented Jun 7, 2026 •
edited
Loading

  • bump minimum elixir to 1.17 (oldest elixir that supports OTP 27)
  • change legacy lockfile to be modern dependencies but with hackney 1.x
  • update CI to test against a matrix of elixir 1.17-1.20, OTP 27-29, and hackney 1.x and 4.x
    • NOT a full matrix -- this seemed like a reasonable middle ground, but probably still overkill if anything
  • got integration tests running:
    • pare down integration tests matrix to one per hackney major version
    • manually install phantom JS since the GitHub runners dont have it pre-installed anymore (and the container images aren't compatible either)
    • pass an explicit port to chromedriver since newer versions randomise it
    • bump action versions (checkout and cache) to their latest
    • anchor the does-not-exist-123 test domain with a trailing dot so DNS wildcards match (I have a *.foo DNS entry locally that was causing this to break)

phinnaeus added 2 commits June 6, 2026 22:27
@phinnaeus
modernize elixir/otp requirements
a04f5f3
@phinnaeus
Get integration_tests running on hosted runners again
1a1878a 
- Run one integration job per supported hackney major (default and
  legacy lockfiles) instead of one per toolchain
- Download PhantomJS, which is no longer preinstalled on runners
- Pass --port=9515 to chromedriver, which now defaults to a random port
- Bump actions/checkout to v6 and actions/cache to v5 (Node 24)
- Run each driver scenario even when an earlier one fails
- Anchor the nonexistent-domain hostname in StatusTest with a trailing
  dot so it cannot resolve through local DNS search domains
@phinnaeus phinnaeus mentioned this pull request Jun 7, 2026
Merged
@mhanberg mhanberg merged commit 6bd13c5 into elixir-wallaby:master Jun 7, 2026
16 checks passed
@mhanberg
Copy link
Copy Markdown
Member

mhanberg commented Jun 7, 2026

❤️

@mhanberg
Copy link
Copy Markdown
Member

mhanberg commented Jun 7, 2026 •
edited
Loading

If you want a few more contributions you could run the "pinact" tool on this to bump and pin all GHA. And make sure the dependabot runs for actions ecosystem with a cooldown.

Also can disable dependabot for elixir, it's not super useful for libraries. @phinnaeus

@phinnaeus phinnaeus deleted the modernize-elixir-req branch June 7, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phinnaeus @mhanberg