Fix credo 1.7 strict findings#117
Merged
Merged
Conversation
phinnaeus
commented
Jun 6, 2026
mhanberg
reviewed
Jun 6, 2026
Resolves Refactor.RedundantWithClauseResult at 123 sites and one Refactor.Nesting finding, then re-enables mix credo --strict on the modern CI entry.
phinnaeus
force-pushed
the
fix-new-credo-issues
branch
from
06f2afc to
b31de9f
Compare
Member
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #116
This PR resolves
Refactor.RedundantWithClauseResultat 123 sites.We could also run credo only on the modern lockfile, I'm on the fence.
Full disclosure: I had claude make these mechanical changes on my behalf.