fix: improve recovery from unexpected semicolons #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Per elixir grammar a lot of those are actually expected semicolons. Elixir uses eol, ; or eol; as eoe. Also stab parens allow semicolons as separators |
Author
|
@lukaszsamson good call, thanks! |
rename eat_* helpers to use `eoe` when it eats eol and ;
doorgan
force-pushed
the
doorgan/semicolon-crashes
branch
from
ff6fd39 to
577de80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a lot of scenarios where the parser would crash on unexpected semicolons, or report the wrong error message.
Some of the errors were originally reported in #48
This PR supercedes part of #56