Implement ~BASH sigil highlighting#522
Open
dbernheisel wants to merge 1 commit intoelixir-lsp:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
~BASHsyntax highlighting provided by the https://hexdocs.pm/bash package. There wasn't a great way to test this, so I had to get VSCode's way of testing grammars setup as well, which is most of the change here.VSCode ships with
shellscriptgrammar, so this shouldn't require any external dependencies. However given textmate's limitations, there's a number of shellscript tokens it cannot highlight without breaking things for the rest of the elixir file, so this limits it a subset (although still helpful) of highlights.Most of the lines in
elixir.jsonare repeated to support all the different fences around sigils, just like regex, but they're all the same.I'm not a VSCode user, so feel free to give it a thorough review.
Reopened #521