fix(expert): default PATH lookup to noninteractive login shell#537
Open
CptnKirk wants to merge 1 commit intoelixir-lang:mainfrom
Open
fix(expert): default PATH lookup to noninteractive login shell#537CptnKirk wants to merge 1 commit intoelixir-lang:mainfrom
CptnKirk wants to merge 1 commit intoelixir-lang:mainfrom
Conversation
Avoid interactive shell startup side effects that can wedge Expert in zle-heavy environments while preserving an opt-in escape hatch for legacy interactive behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXPERT_PATH_SHELL_MODE=interactive.Why
This is a blocking fix for environments where interactive zsh startup triggers
zle/plugin side effects. The previous default could wedge PATH discovery and prevent Expert from starting reliably.A noninteractive login shell is the least surprising default for PATH discovery: we want environment setup, not interactive UI behavior. Interactive shell startup has side effects, and users who need that legacy behavior can still opt back in explicitly.
Testing
just compile expert --warnings-as-errorsjust mix expert format --check-formattedjust test expert --warnings-as-errorsNotes
Users who need the old interactive behavior can opt back in with
EXPERT_PATH_SHELL_MODE=interactive.