Fix Logger.Utils.truncate_n UTF-8 range for two-byte code points#15221
Merged
josevalim merged 1 commit intoelixir-lang:mainfrom Mar 27, 2026
Merged
Conversation
Member
|
@cuiweixie is the test failing before you change? The change is technically correct but this range overlaps with the previous clause, so the previous clause will always match and the test would always pass before too. If that's the case, you can only do the code change. No need for a new test. Thanks! |
Two-byte UTF-8 sequences start at U+0080 (128), not U+007F (127). The previous guard `127..0x07FF` overlapped the single-byte clause and could misclassify U+007F if clause order changed. Add regression tests for U+007F/U+0080 byte boundaries.
cuiweixie
force-pushed
the
fix/logger-truncate-n-utf8-boundary
branch
from
ec36035 to
bace473
Compare
Contributor
Author
got it. only do code change without adding unittest. |
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
127..0x07FFto128..0x07FF. Two-byte UTF-8 sequences start at U+0080 (128); U+007F (127) is still a single byte. The old range overlapped the0..127clause and could misclassify U+007F if clause order ever changed.Logger.UtilsTestfor U+007F/U+0080 byte boundaries.