Skip to content

Improve function argument naming, specs and guards in Mix #15216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 3 commits into from
Mar 26, 2026
+6 −3
Merged

Improve function argument naming, specs and guards in Mix #15216

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b55888b
Improve function argument naming, specs and guards in Mix
eksperimental Mar 25, 2026
a060c99
Apply suggestions by @josevalim
eksperimental Mar 25, 2026
84b3591
Update lib/mix/lib/mix.ex
eksperimental Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/mix/lib/mix.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,8 +612,8 @@ defmodule Mix do
Sets Mix debug mode.
"""
@spec debug(boolean()) :: :ok
def debug(debug) when is_boolean(debug) do
Mix.State.put(:debug, debug)
def debug(enabled?) when is_boolean(enabled?) do
Mix.State.put(:debug, enabled?)
end

@doc """
Expand Down Expand Up @@ -652,6 +652,8 @@ defmodule Mix do
"""
@doc since: "1.10.0"
@spec path_for(:archives | :escripts) :: String.t()
def path_for(kind)

def path_for(:archives) do
System.get_env("MIX_ARCHIVES") || Path.join(Mix.Utils.mix_home(), "archives")
end
Expand All @@ -671,6 +673,7 @@ defmodule Mix do
This function does not start the given applications.
"""
@doc since: "1.15.0"
@spec ensure_application!(Application.app()) :: :ok
def ensure_application!(app) when is_atom(app) do
ensure_application!(app, Mix.State.builtin_apps(), [], %{})
:ok
Expand Down Expand Up @@ -1131,7 +1134,7 @@ defmodule Mix do
end

@doc false
def in_install_project(fun) do
def in_install_project(fun) when is_function(fun, 0) do
case safe_get_installed() do
{id, dynamic_config} ->
config = install_project_config(dynamic_config)
Expand Down
Loading