Fix Adbc.Connection.query_pointer/5 warning when using adbc >= 0.9#1154
Open
nTraum wants to merge 1 commit into
Open
Fix Adbc.Connection.query_pointer/5 warning when using adbc >= 0.9#1154nTraum wants to merge 1 commit into
nTraum wants to merge 1 commit into
Conversation
adbc 0.9 deprecated the 2-arity callback of `Adbc.Connection.query_pointer`. When using explorer with adbc 0.9 or newer, this generates lots of deprecation warnings. This commit fixes it by using the newer 1-arity callback if available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adbc 0.9 deprecated the 2-arity callback of
Adbc.Connection.query_pointer.When using explorer with adbc 0.9 or newer, this generates lots of deprecation warnings. This commit fixes it by using the newer 1-arity callback if available.
The docs of
Adbc.StreamResultmention:I am unsure what to do with information and whether
in the callback is enough to keep the reference alive long enough.