Skip to content

Fix generated nested time array #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jun 24, 2025
Merged

Fix generated nested time array #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ecto/adapters/postgres/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,7 +1767,7 @@ if Code.ensure_loaded?(Postgrex) do

defp column_type(type, opts) when type in ~w(time utc_datetime naive_datetime)a do
generated = Keyword.get(opts, :generated)
[ecto_to_db(type), "(0)", generated_expr(generated)]
[[ecto_to_db(type), "(0)"], generated_expr(generated)]
end

defp column_type(type, opts)
Expand Down
6 changes: 4 additions & 2 deletions test/ecto/adapters/postgres_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2376,12 +2376,14 @@ defmodule Ecto.Adapters.PostgresTest do
{:create, table(:posts),
[
{:add, :tags, {:array, {:array, :text}},
[generated: ~s|ALWAYS AS (ARRAY['foo','bar']) STORED|]}
[generated: ~s|ALWAYS AS (ARRAY['foo','bar']) STORED|]},
{:add, :times, {:array, {:array, :time}},
[generated: ~s|ALWAYS AS (ARRAY['08:00:00','09:00:00']) STORED|]}
]}

assert execute_ddl(create) == [
"""
CREATE TABLE "posts" ("tags" text[][] GENERATED ALWAYS AS (ARRAY['foo','bar']) STORED)
CREATE TABLE "posts" ("tags" text[][] GENERATED ALWAYS AS (ARRAY['foo','bar']) STORED, "times" time(0)[][] GENERATED ALWAYS AS (ARRAY['08:00:00','09:00:00']) STORED)
"""
|> remove_newlines
]
Expand Down
Loading