Internalise Octicons #212
Open
Internalise Octicons #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to run elemental offline
clschnei
approved these changes
Sep 27, 2017
Contributor
clschnei
left a comment
clschnei
left a comment
There was a problem hiding this comment.
Nice catch. These look good to me. I'll let @JedWatson or @jossmac do the offical approval.
Member
|
My only concern is the added weight. Might leave this to @JedWatson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to run elemental offline, the only external dependency is Octicons so i've merged the font into the project and created a new /less/fonts folder