Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
dsanders11
reviewed
Apr 2, 2026
| if (typeof module !== 'undefined' && require.main === module) { | ||
| main(process.argv); | ||
| } | ||
| main(process.argv); |
Member
There was a problem hiding this comment.
Do we know what originally motivated this? Wondering if we should keep it.
Member
Author
There was a problem hiding this comment.
Not sure but as a note I specifically changed this around because require.main === module was tripping over module: preserve.
Member
There was a problem hiding this comment.
Context for the change here: b30d4c3
I'm a little concerned this might cause a regression in tests, but at the same time they're going green. 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly testing how things shake out after the ESM + Node 22 PR.