-
Notifications
You must be signed in to change notification settings - Fork 305
[wip]: Speed up shutdown by brutally killing snapshot processes #3756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ 55 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
6037b8a to
4168319
Compare
2b93719 to
f650b8a
Compare
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Comment |
|
Found 110 test failures on Blacksmith runners: Failures
|
| # need to call `super()` to obtain the original DynamicSupervisor child_spec() to pass as an option to | ||
| # PartitionSupervisor. | ||
| PartitionSupervisor.child_spec( | ||
| child_spec: Supervisor.child_spec(super(opts), shutdown: :brutal_kill), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not specify this shutdown policy on the snapshotter genserver?
31df264 to
0d4debb
Compare
No description provided.