Skip to content

Conversation

@magnetised
Copy link
Contributor

@magnetised magnetised commented Jan 15, 2026

Now that SQLite has all the shape data we don't need the storage callbacks that retreive it, and also do not need to serialize the shape to disk at all.

I've kept the get_all_stored_shape_handles/1 callback to allow for some kind of async reconciliation process that can detect and remove orphaned storage instances.

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.31%. Comparing base (ba6dd2c) to head (8a381da).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3717      +/-   ##
==========================================
- Coverage   87.36%   87.31%   -0.05%     
==========================================
  Files          23       23              
  Lines        2011     2011              
  Branches      528      529       +1     
==========================================
- Hits         1757     1756       -1     
- Misses        252      253       +1     
  Partials        2        2              
Flag Coverage Δ
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.48% <ø> (ø)
packages/start 82.83% <ø> (ø)
packages/typescript-client 93.39% <ø> (-0.08%) ⬇️
packages/y-electric 56.05% <ø> (ø)
typescript 87.31% <ø> (-0.05%) ⬇️
unit-tests 87.31% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blacksmith-sh

This comment has been minimized.

@magnetised magnetised force-pushed the magnetised/cleanup-storage-behaviour branch 3 times, most recently from 127a6bc to 8410e0d Compare January 22, 2026 09:45
@blacksmith-sh

This comment has been minimized.

@magnetised magnetised force-pushed the magnetised/cleanup-storage-behaviour branch from 8410e0d to ede3b69 Compare January 22, 2026 11:57
@magnetised magnetised force-pushed the magnetised/cleanup-storage-behaviour branch from ede3b69 to 8a381da Compare January 27, 2026 11:00
@magnetised magnetised marked this pull request as ready for review January 27, 2026 11:02
@blacksmith-sh

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants