libvirt: Skip unsupported firmware types#1
Open
Brittlejf wants to merge 1 commit intoelastx/yogafrom
Open
Conversation
Ignore (1) stateless mode firmware and (2) memory device firmware which do not include a few core keys such as nvram-template. This is a temporal (and backportable) workaround until firmware detection using libvirt's internal feature is implemented by [1] [1] https://blueprints.launchpad.net/nova/+spec/libvirt-firmware-auto-selection Closes-Bug: #2122288 Change-Id: I99bc36fdd5df816c9ae374db71e4734fb7fc467b Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com> (cherry picked from commit d2188b9) (cherry picked from commit 53c253d)
Member
Author
|
Fixes errors that appear during creation of uefi/q35 machine-type instances in Nova on Yoga in Ubuntu 24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore (1) stateless mode firmware and (2) memory device firmware which do not include a few core keys such as nvram-template. This is a temporal (and backportable) workaround until firmware detection using libvirt's internal feature is implemented by [1]
[1] https://blueprints.launchpad.net/nova/+spec/libvirt-firmware-auto-selection
Closes-Bug: #2122288
Change-Id: I99bc36fdd5df816c9ae374db71e4734fb7fc467b
(cherry picked from commit d2188b9) (cherry picked from commit 53c253d)