Skip to content

[Box Events] Update field mapping to account for non-boolean values#17413

Merged
efd6 merged 8 commits intomainfrom
kyleonk8s-box-events-field-remap
Mar 25, 2026
Merged

[Box Events] Update field mapping to account for non-boolean values#17413
efd6 merged 8 commits intomainfrom
kyleonk8s-box-events-field-remap

Conversation

@KyleOnK8s
Copy link
Copy Markdown
Contributor

@KyleOnK8s KyleOnK8s commented Feb 13, 2026

Proposed commit message

Box Events sends either null or an email to box.source.login when using the admin_logs_streaming setting. Setting this field to a boolean causes data set quality issues and fields to become ignored.

Changing this to a keyword should resolve issues with data set quality.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@KyleOnK8s KyleOnK8s added the bug Something isn't working, use only for issues label Feb 13, 2026
@KyleOnK8s KyleOnK8s requested a review from a team as a code owner February 13, 2026 23:53
Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an elastic-package build (or just the application of the following diff):

diff --git a/packages/box_events/docs/README.md b/packages/box_events/docs/README.md
index 1b09c46a4d..f3437d7c42 100644
--- a/packages/box_events/docs/README.md
+++ b/packages/box_events/docs/README.md
@@ -227,7 +227,7 @@ Preserves a raw copy of the original event, added to the field `event.original`.
 | box.source.item_status | Defines if this item has been deleted or not. active when the item has is not in the trash trashed when the item has been moved to the trash but not deleted deleted when the item has been permanently deleted. Value is one of `active`, `trashed`, `deleted` | keyword |
 | box.source.job_title | User job title | boolean |
 | box.source.language | User preferred language | boolean |
-| box.source.login | User login | boolean |
+| box.source.login | User login | keyword |
 | box.source.max_upload_size | Max upload size | boolean |
 | box.source.modified_at | The date and time at which this folder was last updated | date |
 | box.source.modified_by.id | The unique identifier for this user that last modified the file. | keyword |

Can you add a test for this? There is no event in the pipeline tests for this field, which is presumably why it has persisted so long.

@andrewkroh andrewkroh added Integration:box_events Box Events Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Feb 16, 2026
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic
Copy link
Copy Markdown

botelastic Bot commented Mar 18, 2026

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added Stalled and removed Stalled labels Mar 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 23, 2026

✅ Vale Linting Results

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@KyleOnK8s
Copy link
Copy Markdown
Contributor Author

This needs an elastic-package build (or just the application of the following diff):

Can you add a test for this? There is no event in the pipeline tests for this field, which is presumably why it has persisted so long.

@efd6 Sorry for the delay. This should be done. Can you re-review please?

@KyleOnK8s KyleOnK8s force-pushed the kyleonk8s-box-events-field-remap branch from d5f2794 to 3beafdc Compare March 23, 2026 19:10
Comment thread packages/box_events/data_stream/events/_dev/test/pipeline/test-source-login.log Outdated
@efd6
Copy link
Copy Markdown
Contributor

efd6 commented Mar 23, 2026

/test

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Mar 23, 2026
Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the change in the fields.yml and then regenerate the documentation with elastic-package build.

Comment thread packages/box_events/data_stream/events/fields/fields.yml Outdated
Comment thread packages/box_events/docs/README.md Outdated
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6
Copy link
Copy Markdown
Contributor

efd6 commented Mar 23, 2026

Can you use the text that I suggested? At the moment, it is not grammatically correct.

@KyleOnK8s
Copy link
Copy Markdown
Contributor Author

@efd6 done. Sorry, I didn't realize you had changed the grammar. I didn't edit that field in this PR so I was just adding the periods to make the linter happy.

I had to remove the colon in your example. It threw an error because it thought I was trying to define another key. \: didn't work either so I just removed it.

@KyleOnK8s KyleOnK8s force-pushed the kyleonk8s-box-events-field-remap branch from e7690bc to c01bdac Compare March 24, 2026 14:39
@efd6
Copy link
Copy Markdown
Contributor

efd6 commented Mar 24, 2026

/test

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit e49428a into main Mar 25, 2026
10 checks passed
@efd6 efd6 deleted the kyleonk8s-box-events-field-remap branch March 25, 2026 00:42
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package box_events - 3.1.2 containing this change is available at https://epr.elastic.co/package/box_events/3.1.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:box_events Box Events Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Box Events]: box.source.login is not always boolean

4 participants