-
Notifications
You must be signed in to change notification settings - Fork 523
[cloudflare_logpush] Add support for the data deduplication toggle for AWS S3 input #16688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cloudflare_logpush] Add support for the data deduplication toggle for AWS S3 input #16688
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
...ages/cloudflare_logpush/data_stream/access_request/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
ShourieG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my end but can you get this reviewed by @kcreddy also before merging
kcreddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions. LGTM overall. Thanks!
| Add support for the data deduplication toggle for AWS S3 input. By default, it is enabled. | ||
| This setting prevents duplicates but may result in a lower indexing rate | ||
| because Elasticsearch must check for existing documents before indexing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Add support for the data deduplication toggle for AWS S3 input. By default, it is enabled. | |
| This setting prevents duplicates but may result in a lower indexing rate | |
| because Elasticsearch must check for existing documents before indexing. | |
| Add `Enable Data Deduplication` toggle for AWS S3 input. By default, it is enabled. | |
| When enabled, this setting prevents duplicates but may result in a lower indexing rate | |
| because Elasticsearch must check for existing documents before indexing. |
💚 Build Succeeded
History
|
|
Package cloudflare_logpush - 1.42.0 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.42.0/ |
|
Package cloudflare_logpush - 1.43.0 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.43.0/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues