Skip to content

Conversation

@brijesh-elastic
Copy link
Collaborator

Proposed commit message

AWS S3 input does "_id-Based Deduplication"[1] and generates "_id" by default.
This enhancement introduces "Data Deduplication" integration setting to allow users
to deduplicate data at the cost of indexing.
When users disable this setting, the "_id" generated by the input should
also be deleted. This PR does that.

[1]: https://www.elastic.co/docs/reference/beats/filebeat/filebeat-input-aws-s3#_document_id_generation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/cloudflare_logpush directory.
  • Run the following command to run tests.

elastic-package test

Related issues

@brijesh-elastic brijesh-elastic self-assigned this Dec 24, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner December 24, 2025 08:39
@brijesh-elastic brijesh-elastic added enhancement New feature or request Integration:cloudflare_logpush Cloudflare Logpush Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Dec 24, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my end but can you get this reviewed by @kcreddy also before merging

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. LGTM overall. Thanks!

Comment on lines 5 to 7
Add support for the data deduplication toggle for AWS S3 input. By default, it is enabled.
This setting prevents duplicates but may result in a lower indexing rate
because Elasticsearch must check for existing documents before indexing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add support for the data deduplication toggle for AWS S3 input. By default, it is enabled.
This setting prevents duplicates but may result in a lower indexing rate
because Elasticsearch must check for existing documents before indexing.
Add `Enable Data Deduplication` toggle for AWS S3 input. By default, it is enabled.
When enabled, this setting prevents duplicates but may result in a lower indexing rate
because Elasticsearch must check for existing documents before indexing.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @brijesh-elastic

@brijesh-elastic brijesh-elastic merged commit b54e8d5 into elastic:main Dec 31, 2025
8 checks passed
@elastic-vault-github-plugin-prod

Package cloudflare_logpush - 1.42.0 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.42.0/

@elastic-vault-github-plugin-prod

Package cloudflare_logpush - 1.43.0 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.43.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cloudflare_logpush Cloudflare Logpush Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants