-
Notifications
You must be signed in to change notification settings - Fork 523
Fix durationMs parsing in auditlogs data stream
#16674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💚 CLA has been signed |
|
Hey @gregorywychowaniec-zt, thanks for raising this PR! 🙇 I'll open an issue/PR to fix this field across all Azure integrations. |
zmoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this @gregorywychowaniec-zt.
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
packages/azure/data_stream/auditlogs/_dev/test/pipeline/test-audit-logs-duration-as-string.log
Outdated
Show resolved
Hide resolved
packages/azure/data_stream/auditlogs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
|
I created the issue #16677 to normalize |
|
@gregorywychowaniec-zt I have resolved the merge conflict and with current approvals, this should be good to go |
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @zmoog |
|
Package azure - 1.34.1 containing this change is available at https://epr.elastic.co/package/azure/1.34.1/ |
Proposed commit message
Same as encoutered in #15976, we got some auditlogs with durationMs as a string that break the pipeline. So same fix for auditlogs here :
azure.auditlogs.durationMsaslongtype if the value comes as stringChecklist
changelog.ymlfile.How to test this PR locally