Skip to content

Conversation

@jeffvestal
Copy link
Contributor

I added a new directory for video related content as we are starting to have more, seemed to make sense but I'm open to putting it someplace else.

Also added a python notebook for a upcoming video

@gitnotebooks
Copy link

gitnotebooks bot commented Dec 16, 2025

Found 2 changed notebooks. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/514

@cla-checker-service
Copy link

cla-checker-service bot commented Dec 16, 2025

💚 CLA has been signed

@jeffvestal
Copy link
Contributor Author

@SharonRosencwaig1 or @ElishevaStern
I signed that contributor agreement twice, one with my work email and one with my gmail that is tied to my GH.
Do you know how to get past that?

@xeraa
Copy link

xeraa commented Dec 17, 2025

But are your commits tied to one of those emails?

@jeffvestal
Copy link
Contributor Author

ya i found a 3rd email on my GH account i just signed it with that

@jeffvestal
Copy link
Contributor Author

the pre-commit was failing with a message about no empty last line
i added one
pre-commit still failing with exit 1 but i don't see a reason

@jeffvestal
Copy link
Contributor Author

@xeraa do you know why this is failing now (the agreement is fine now)?
the bot on here tells me its an issue with the pre-commit code not the notebook, but i'm not so sure

@xeraa
Copy link

xeraa commented Dec 18, 2025

I think I patched it up in #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants