Describe skip label availability and add skip-specific comment#53
Open
Describe skip label availability and add skip-specific comment#53
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Mpdreamz
requested changes
Apr 2, 2026
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
Updated review — my earlier finding #1 (missing skip-labels output) is stale: docs-builder#3013 adds it. That PR should be listed as a prerequisite here.
Two findings remain:
| # | Severity | Finding |
|---|---|---|
| 1 | 🟡 UX | Skip comments add noise — contributors who added a skip label don't need confirmation |
| 2 | 🟡 Logic | skipped status fires for body-only edits, bot commits, AND label exclusions — only the last involves labels |
Recommendation: Drop post-skipped-comment.js. Keep the skip-label listing in the failure comment only (for no-label status) — that's where the info is actionable. The failure comment changes in post-failure-comment.js are good and should stay.
Also: link docs-builder#3013 as a prerequisite — this PR is broken without it.
* Let docs-builder know it's running on CI to set landing-page-path * Set CI again.
* Add agentic workflow infrastructure and docs-check workflow Introduces gh-aw agentic workflow support alongside the existing composite actions. Workflow .md sources live in workflows/ as a library; a compile script copies them into .github/workflows/ for the gh-aw compiler and produces .lock.yml files that consumer repos reference via workflow_call. First workflow: docs-check — analyzes PRs/commits for documentation impact using the Elastic Docs MCP server and posts structured findings as comments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Simplify tooling: use gh extension instead of Go binary Replace go install with gh extension install for the gh-aw compiler. Drop actionlint binary download — the repo already has it via pre-commit. Remove bin/ dependency entirely. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix CI failures and address review feedback - Move `roles` under `on:` (latest gh-aw schema change) - Exclude .lock.yml from pre-commit trailing-whitespace and end-of-file-fixer - Replace custom lint/release Makefile targets with `pre-commit run --all` - Remove release target (release-drafter handles releases) - Recompile lock file with latest gh-aw Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix CI: recompile with latest gh-aw, exclude lock files from actionlint - Update gh-aw extension (v0.63.0 → v0.65.5) and recompile lock file - Exclude .lock.yml from actionlint pre-commit hook (generated files reference secrets injected by the gh-aw runtime) - Fix .gitattributes missing trailing newline Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Rename workflows/ to agentic-workflows/ Update all references in compile script, Makefile, CI, README, DEVELOPING.md, and workflow docs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add /create-agentic-workflow Claude skill Interactive skill that scaffolds the three required files for a new gh-aw agentic workflow: source .md, example.yml trigger, and README. Guides users through pattern selection, trigger config, and prompt structure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Teach skill about fragment selection and creation Add Step 3 that reads available fragments, explains what each provides and when to include it, documents import rules, and guides users on when to create new fragments vs. reuse existing ones. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…#45) * Harden release workflows against tag injection and credential leakage Made-with: Cursor * Set workflow-level permissions to {} for least-privilege The job already declares contents: write, so the workflow-level contents: read was redundant. Empty permissions at workflow level ensures no implicit grants. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Member
|
I think that this PR might cover #51 by providing to users which label to use to ignore the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on elastic/docs-builder#3013
This pull request updates the changelog automation workflow to improve communication with contributors about changelog label requirements and skipping logic. It enhances PR comments to clarify which labels can be used to skip changelog generation and confirms when changelog generation is skipped due to label rules.
Improvements to PR comments and workflow behavior:
Workflow and script changes:
SKIP_LABELSas an environment variable to the comment-posting scripts, enabling them to display skip label information. [1] [2]post-skipped-comment.js, to handle posting comments when changelog generation is skipped. [1] [2]post-failure-comment.js) was updated to include skip label details and improved messaging.