Do not install metrics-server addon automatically.#8653
Open
MartinEmrich wants to merge 1 commit intoeksctl-io:mainfrom
Open
Do not install metrics-server addon automatically.#8653MartinEmrich wants to merge 1 commit intoeksctl-io:mainfrom
MartinEmrich wants to merge 1 commit intoeksctl-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this patch, the metrics-server addon no longer gets installed as a core addon. This was not documented, and conflicts with users managing their own installation of metric-server.
This should not affect existing clusters, and brings creation of new clusters in line with the documentation and established behavior.
fixes: #8652
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯