Replace m5.large -> t3.medium as default instance type#8623
Draft
butlermg wants to merge 1 commit intoeksctl-io:mainfrom
Draft
Replace m5.large -> t3.medium as default instance type#8623butlermg wants to merge 1 commit intoeksctl-io:mainfrom
butlermg wants to merge 1 commit intoeksctl-io:mainfrom
Conversation
Contributor
|
Hello butlermg 👋 Thank you for opening a Pull Request in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: [Feature] Replace m5.large as default instance type
Description
Some AWS regions do not currently support the default
m5.largeinstance types. Spinning up new node groups in these regions with default settings will result in empty node groups.The below changes swap the default instance type
m5.largewith the more modern and widely availablet3.mediuminstance type, which is also the default instance type for node groups created through the EKS console.Also included are some documentation changes, though these are not necessary.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯