Skip to content

Conversation

@wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR allows py-matplotlib to be compiled with gcc again as well. There are some issues with concretization when we have the clang constraint, so I'm hoping the issue with gcc and LTO is resolved by now...

Copilot AI review requested due to automatic review settings December 31, 2025 01:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the compiler-specific constraint requiring py-matplotlib to be built with Clang. The change allows py-matplotlib to use the default GCC compiler, assuming that previous issues with GCC and LTO have been resolved.

Key Changes

  • Removed the %clang requirement for py-matplotlib from packages.yaml
  • py-matplotlib will now default to GCC compilation as per the global compiler preference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc force-pushed the py-matplotlib-rm-require-clang branch from ee7661d to 089730f Compare January 1, 2026 15:57
Copilot AI review requested due to automatic review settings January 3, 2026 03:34
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked like CI failures are irrelevant.

@wdconinc
Copy link
Contributor Author

wdconinc commented Jan 3, 2026

Looked like CI failures are irrelevant.

Actually, I think they are relevant. I don't know why it wants to build a new llvm because of this change.

@veprbl
Copy link
Member

veprbl commented Jan 3, 2026

Please give a link, I only saw a few docker socket ones.

@wdconinc
Copy link
Contributor Author

wdconinc commented Jan 3, 2026

Please give a link, I only saw a few docker socket ones.

Maybe I'm thinking of another branch. Will post a link if it repeats.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@wdconinc wdconinc enabled auto-merge (squash) January 3, 2026 04:38
@wdconinc
Copy link
Contributor Author

wdconinc commented Jan 3, 2026

Please give a link, I only saw a few docker socket ones.

Seems fine now. I thought it previously wanted to build a whole new llvm for iwyu in this PR...

@veprbl
Copy link
Member

veprbl commented Jan 3, 2026

It's not happy:

ImportError: /opt/local/lib/python3.13/site-packages/matplotlib/_path.cpython-313-x86_64-linux-gnu.so: undefined symbol: _ZN3agg10curve3_div4initEdddddd

@wdconinc
Copy link
Contributor Author

wdconinc commented Jan 3, 2026

It's not happy:

ImportError: /opt/local/lib/python3.13/site-packages/matplotlib/_path.cpython-313-x86_64-linux-gnu.so: undefined symbol: _ZN3agg10curve3_div4initEdddddd

Yeah, that was the original reason for %clang... So, not fixed then, clearly.

This is an underlying issue in meson. It uses the wrong (mismatched) ar when linking with lto (which the spack build enforces).

  • no clear place to patch meson to do this better
  • could make lto optional instead of enforcing for GCC
  • could set $AR to the correct gcc-ar in spack

Leaving PR open for tracking.

@wdconinc
Copy link
Contributor Author

wdconinc commented Jan 4, 2026

This probably needs under the extra_attributes for GCC:

        environment:
          set:
            GCC_AR: /usr/bin/gcc-ar-14

Refs:

Copilot AI review requested due to automatic review settings January 4, 2026 20:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 4, 2026 20:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings January 4, 2026 20:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@wdconinc wdconinc merged commit f6a21c4 into master Jan 5, 2026
62 of 68 checks passed
@wdconinc wdconinc deleted the py-matplotlib-rm-require-clang branch January 5, 2026 20:35
@wdconinc wdconinc mentioned this pull request Jan 6, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants