-
Notifications
You must be signed in to change notification settings - Fork 5
fix: release py-matplotlib from require: %clang #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the compiler-specific constraint requiring py-matplotlib to be built with Clang. The change allows py-matplotlib to use the default GCC compiler, assuming that previous issues with GCC and LTO have been resolved.
Key Changes
- Removed the
%clangrequirement for py-matplotlib from packages.yaml - py-matplotlib will now default to GCC compilation as per the global compiler preference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ee7661d to
089730f
Compare
veprbl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked like CI failures are irrelevant.
Actually, I think they are relevant. I don't know why it wants to build a new llvm because of this change. |
|
Please give a link, I only saw a few docker socket ones. |
Maybe I'm thinking of another branch. Will post a link if it repeats. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Seems fine now. I thought it previously wanted to build a whole new llvm for iwyu in this PR... |
|
It's not happy: |
Yeah, that was the original reason for This is an underlying issue in meson. It uses the wrong (mismatched)
Leaving PR open for tracking. |
|
This probably needs under the extra_attributes for GCC: environment:
set:
GCC_AR: /usr/bin/gcc-ar-14Refs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Briefly, what does this PR introduce?
This PR allows py-matplotlib to be compiled with gcc again as well. There are some issues with concretization when we have the clang constraint, so I'm hoping the issue with gcc and LTO is resolved by now...