Truncate drop_term #88
Merged
+100
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add TermManagement::DropTerm - match it in subroutine - change term and comment accordingly addresses ehrtools#87
Error message comes from the Rust side
em-baggie
approved these changes
Jun 11, 2025
Collaborator
em-baggie
left a comment
em-baggie
left a comment
There was a problem hiding this comment.
Looks great, and tests are very comprehensive
| TermManagement::First => Some(format!("{code} truncated to 3 digits")), | ||
| let (term, comment) = match term_management { | ||
| TermManagement::DropTerm => { | ||
| (None, Some("Truncated to 3 digits, term discarded".to_string())) |
Collaborator
There was a problem hiding this comment.
Looks good, with clear comments for each term management
|
|
||
| observed_codelist.truncate_to_3_digits(TermManagement::DropTerm)?; | ||
|
|
||
| assert_eq!(observed_codelist, expected_codelist); |
Collaborator
There was a problem hiding this comment.
Nice clear tests, I like how you set it up as observed vs expected codelist, it's very easy to read
CarolineMorton
approved these changes
Jun 11, 2025
Collaborator
CarolineMorton
left a comment
CarolineMorton
left a comment
There was a problem hiding this comment.
Realy great work here @oylenshpeegul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the DropTerm option to TermManagement as in #87
Updated the Python bindings too, which is good because I found a problem with error.rs back on the Rust side.
Closes #87