fix: optimize block creation by using bulk operations in modulestore #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the block creation logic in
view_handlers.pyto ensure that all operations related to creating and syncing a block are performed within a bulk operation context, improving data consistency and performance.Improvements to block creation and synchronization:
modulestoreis instantiated and itsbulk_operationscontext is used when creating a new block, so all related changes are grouped and atomic.storeinstantiation to the top of the function and reused it in both the block creation and library content synchronization steps, reducing redundant code and potential errors.Testing instructions
Please follow the instructions to test eduNEXT/frontend-app-authoring#2; the difference you would find with and without this change is that this allows adding problems again and again