Migration of Tool from JavaScript to Typescript#73
Open
Koppeks wants to merge 6 commits intoeditor-js:masterfrom
Open
Migration of Tool from JavaScript to Typescript#73Koppeks wants to merge 6 commits intoeditor-js:masterfrom
Koppeks wants to merge 6 commits intoeditor-js:masterfrom
Conversation
…, remove error throws
…statement to check imageHolder
…d console.log, added proper type for renderSettings return
Author
|
I addressed all the reviews that were pending, let me know if I miss something or you need more changes |
dependentmadani
left a comment
dependentmadani
left a comment
There was a problem hiding this comment.
well done, few modifications needs to be done
|
Please make sure to not resolve the conversation next time, it is up to the reviewer to resolve it when it is fixed. |
dependentmadani
requested changes
Oct 15, 2024
| * @returns {Array} | ||
| */ | ||
| renderSettings() { | ||
| renderSettings(): Array<TuneSetting> { |
There was a problem hiding this comment.
this member function needs jsdocs
| _make(tagName, classNames = null, attributes = {}) { | ||
|
|
||
|
|
||
| _make(tagName: string, classNames?: string[] | string, attributes: object = {}): HTMLElement | HTMLImageElement{ |
There was a problem hiding this comment.
can you find a way to reduce the length of this line, so it can be simple to read?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the tool from JavaScript to TypeScript, enhancing static type-checking, improved maintainability, and better developer tooling support.
The migration includes type definitions, interface creation, and refactoring to ensure type safety across the code.
Issue #72