Fix flaky basic-tool-calling-prompt-test #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrowadam
force-pushed
the
fix-flaky-chat-test
branch
from
16ee285 to
5588c0a
Compare
ericdallo
reviewed
Jan 21, 2026
ericdallo
reviewed
Jan 21, 2026
The test was expecting a strict order of messages, but there's a race
condition between progress messages ("Calling tool", "Generating") and
tool state messages (toolCallRunning, toolCalled). Their relative order
in the middle section is non-deterministic.
Changed from strict ordering to using m/in-any-order which checks that
all expected messages are present without requiring a specific order.
🤖 Generated with [eca](https://eca.dev)
Co-Authored-By: eca <noreply@eca.dev>
bobrowadam
force-pushed
the
fix-flaky-chat-test
branch
from
5588c0a to
a356f72
Compare
Contributor
Author
|
@ericdallo Fixed PR comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix flaky
basic-tool-calling-prompt-testthat was causing intermittent CI failures.The test was expecting a strict order of messages, but there's a race condition between progress messages ("Calling tool", "Generating") and tool state messages (toolCallRunning, toolCalled). Changed from strict ordering to using
m/in-any-orderwhich checks that all expected messages are present without requiring a specific order.N/A - test-only change that doesn't affect end users.
🤖 Generated with eca