Optimize large shell tool output #275
Closed
+361
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Auto-allow reading shell output cache files without approval Shell output cache files (~/.cache/eca/*/shell-output/*) are auto-allowed for reading without requiring additional user approval, since the original shell command was already approved.
bobrowadam
force-pushed
the
optimize-large-shell-output
branch
from
b1fc834 to
b18b402
Compare
The shell-output-cache-dir-test was checking for ".cache/eca" with forward slashes, but Windows uses backslashes in paths. Normalize to forward slashes for cross-platform compatibility. 🤖 Generated with [eca](https://eca.dev) Co-Authored-By: eca <noreply@eca.dev>
ericdallo
reviewed
Jan 21, 2026
| input (assoc :in input))))) | ||
|
|
||
| (defn ^:private shell-command [arguments {:keys [db tool-call-id call-state-fn state-transition-fn]}] | ||
| (defn ^:private workspaces-hash |
Member
There was a problem hiding this comment.
Why are we duplicating this function if it exists in eca.cache/workspaces-hash?
ericdallo
reviewed
Jan 21, 2026
| key (.encodeToString encoder digest)] | ||
| (subs key 0 (min 8 (count key))))) | ||
|
|
||
| (defn ^:private shell-output-cache-dir |
Member
There was a problem hiding this comment.
I wonder if this functoin is better to live in eca.cache along with the workspace-cache-file
ericdallo
reviewed
Jan 21, 2026
Member
ericdallo
left a comment
ericdallo
left a comment
There was a problem hiding this comment.
@bobrowadam thank you for the help, but I wish we could discuss this better in a issue before a PR, I believe @zikajk has some concerns about this approach
Contributor
Author
@ericdallo sure no problem. I'll be happy to be part of a discussion regarding optimizing token usage this way or another. |
Contributor
Author
|
closing this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
~/.cache/eca/{workspace-hash}/shell-output/) instead of returning inline. Reduces LLM context bloat for commands likefind,git log, etc.Details
toolCall.shellCommand.outputFileThreshold(default: 1000)