fix: select newest subgraph version regardless of sync status #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Post-Horizon, pre-Horizon indexers
cannot serve queries (they lack TAP v2
receipt support). The previous logic
would select an older version if it
had indexers 'near chain head',
causing queries to fail when routed to
incompatible pre-Horizon indexers.
This change removes the sync-status
check from version selection, ensuring
the newest version with allocations is
always selected. Sync status
filtering
is handled downstream in candidate
selection where it correctly filters
within protocol-compatible indexers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-Horizon, pre-Horizon indexers cannot serve queries (they lack TAP v2 receipt support). The previous logic would select an older version if it had indexers 'near chain head', causing queries to fail when routed to incompatible pre-Horizon indexers.
This change removes the sync-status check from version selection, ensuring the newest version with allocations is always selected. Sync status filtering is handled downstream in candidate selection where it correctly filters within protocol-compatible indexers.
Signed off by Joseph Livesey joseph@semiotic.ai