fix(metrics): standardize dataset labels and correct GC metric names#2027
Merged
fix(metrics): standardize dataset labels and correct GC metric names#2027
Conversation
Replace split dataset_name/dataset_namespace labels with a single `dataset` label formatted as `namespace/name` for consistent cardinality across components. - Drop redundant `dataset_name` label from `dataset_kvs` in server metrics - Remove `dataset_name` from three inline `kv` arrays in `flight.rs` - Replace `dataset_name` + `dataset_namespace` pair in `worker-core` `base_kvs` with a single `dataset` = `namespace/name` label - Update `docs/metrics.md` to reflect `dataset` label on all query and streaming metrics (previously incorrectly documented as "Labels: None")
… with code Fix copy-paste errors where `expired_files_found` and `expired_entries_deleted` were registered with wrong OTel metric names, causing silent collisions and missing data in Prometheus. - Rename `expired_files_found` metric from `"files_not_found"` to `"expired_files_found"` (was colliding with the actual `files_not_found` counter) - Rename `expired_entries_deleted` metric from `"files_failed_to_delete"` to `"expired_entries_deleted"` with corrected description - Replace stale `version` label with `manifest_hash` across all dump/extraction metric docs - Add missing `manifest_hash` and `job_id` labels to compaction and GC metric docs
Theodus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace split
dataset_name/dataset_namespacelabels with a singledatasetlabel formatted asnamespace/namefor consistent cardinality across components.dataset=namespace/namelabel, replacing the inconsistent mix ofdataset_name,dataset_namespace, anddatasetlabels across server and worker-coreexpired_files_foundwas registered as"files_not_found"(colliding with the real counter) andexpired_entries_deletedwas registered as"files_failed_to_delete"docs/metrics.mdwith actual code: adddatasetlabel to all query/streaming metrics, replace staleversionwithmanifest_hash, and add missingmanifest_hash/job_idlabels to dump, compaction, and GC metrics