Skip to content

Refactor NSS and DNSS implementations for improved readability and modularity #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eclipse0922 wants to merge 2 commits into
base: master
Choose a base branch
from
+999 −445
Open

Refactor NSS and DNSS implementations for improved readability and modularity #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7adea4
Refactor NSS and DNSS implementations for improved readability and mo…
eclipse0922 Feb 8, 2026
4bb5106
ai code review
eclipse0922 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pr-agent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ jobs:
CONFIG__CUSTOM_MODEL_MAX_TOKENS: "32768"
CONFIG__RESPONSE_LANGUAGE: "ko-KR"

PR_REVIEWER__NUM_CODE_SUGGESTIONS: "3"
PR_REVIEWER__NUM_CODE_SUGGESTIONS: "5"
PR_REVIEWER__REQUIRE_SECURITY_REVIEW: "true"
PR_REVIEWER__EXTRA_INSTRUCTIONS: "버그, 성능 문제, 메모리 누수를 분석해주세요."

PR_CODE_SUGGESTIONS__NUM_CODE_SUGGESTIONS: "5"
PR_CODE_SUGGESTIONS__EXTRA_INSTRUCTIONS: "구체적인 코드 수정안을 제시해주세요."

PR_DESCRIPTION__PUBLISH_LABELS: "true"

PR_DESCRIPTION__ADD_ORIGINAL_USER_DESCRIPTION: "true"

run: |
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
build/
build-cuda/
21 changes: 21 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
cmake_minimum_required(VERSION 3.20)

project(DNSS LANGUAGES CXX)

option(DNSS_ENABLE_CUDA "Enable CUDA acceleration for DNSS rotational feature computation" OFF)

add_library(dnss NSS.cpp NSS.h)
Copy link

@gemini-code-assist gemini-code-assist bot Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's generally not recommended to include header files in add_library. While it might work with some generators (like adding the file to a Visual Studio project), it's not a portable practice and can have unintended side effects with others. Headers are made available to targets via target_include_directories, which is already correctly used.

add_library(dnss NSS.cpp)

target_include_directories(dnss PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
target_compile_features(dnss PUBLIC cxx_std_17)

if(DNSS_ENABLE_CUDA)
enable_language(CUDA)
find_package(CUDAToolkit REQUIRED)
if(NOT CMAKE_CUDA_ARCHITECTURES)
set(CMAKE_CUDA_ARCHITECTURES native)
endif()
target_sources(dnss PRIVATE dnss_cuda.cu)
target_compile_definitions(dnss PRIVATE DNSS_HAS_CUDA=1)
target_link_libraries(dnss PUBLIC CUDA::cudart)
set_target_properties(dnss PROPERTIES CUDA_SEPARABLE_COMPILATION ON CUDA_RESOLVE_DEVICE_SYMBOLS ON)
endif()
Loading