Refactor NSS and DNSS implementations for improved readability and modularity#3
Closed
eclipse0922 wants to merge 1 commit intomasterfrom
Closed
Refactor NSS and DNSS implementations for improved readability and modularity#3eclipse0922 wants to merge 1 commit intomasterfrom
eclipse0922 wants to merge 1 commit intomasterfrom
Conversation
Owner
eclipse0922
commented
Feb 8, 2026
eclipse0922
commented
- Rewrote legacy code into clean C++17 style.
- Added missing method implementations and input validation.
- Introduced options struct for configurable parameters in NSS and DNSS.
- Implemented CUDA support for DNSS rotational feature computation.
- Added new CMake configuration for building with or without CUDA.
- Updated README to reflect changes and provide build instructions.
- Added .gitignore to exclude build directories.
…dularity - Rewrote legacy code into clean C++17 style. - Added missing method implementations and input validation. - Introduced options struct for configurable parameters in NSS and DNSS. - Implemented CUDA support for DNSS rotational feature computation. - Added new CMake configuration for building with or without CUDA. - Updated README to reflect changes and provide build instructions. - Added .gitignore to exclude build directories.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Preparing PR description... |
|
Preparing review... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.